Skip to content

fix #332 #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021
Merged

fix #332 #333

merged 2 commits into from
Jun 11, 2021

Conversation

xxcxy
Copy link
Contributor

@xxcxy xxcxy commented Jun 11, 2021

No description provided.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xxcxy works good, just one small improvement for the Swagger file mentioned below.

items:
type: string
enum: ["pending", "partially-completed", "completed", "cancelled"]
- type: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also defined enum: ["pending", "partially-completed", "completed", "cancelled"] for the type: string as it was before.

items:
type: string
enum: ["pending", "partially-completed", "completed", "cancelled"]
- type: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@maxceem maxceem self-requested a review June 11, 2021 10:40
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xxcxy as it works well, merging like this for testing. No need to fix Swagger.

@maxceem maxceem merged commit 3f131e0 into topcoder-platform:dev Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants